feat(code): file picker on quill autocomplete#2101
Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/command/components/FilePicker.tsx:91-96
The `className="block"` override on `AutocompleteItem` diverges from the sibling `CommandMenu` usage and may cancel out the default flex layout that quill's `AutocompleteItem` applies. With `display: block`, the `FileIcon` SVG, the filename text node, and the directory `<span>` will be rendered as inline content rather than flex-aligned siblings, which can produce misaligned or run-together text. `CommandMenu` omits this class and achieves correct icon + label alignment. Consider removing it, or wrapping children in a `<div className="flex items-center gap-2">` if an explicit flex row is needed.
```suggestion
<AutocompleteItem
key={file.path}
value={file.path}
onClick={() => handleSelect(file.path)}
>
```
Reviews (1): Last reviewed commit: "feat(code): file picker on quill autocom..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/command/components/FilePicker.tsx:104
When `sections[0]?.label` is truthy the template literal resolves to `"max-h-[60vh] "` (trailing space). While harmless in practice, a simple ternary keeps intent clearer and avoids the superfluous whitespace.
```suggestion
className={sections[0]?.label ? "max-h-[60vh]" : "max-h-[60vh] pt-1"}
```
Reviews (2): Last reviewed commit: "feat(code): file picker recent + other f..." | Re-trigger Greptile |
Contributor
|
Reviews (3): Last reviewed commit: "fix(code): cap empty-query file picker l..." | Re-trigger Greptile |
21 tasks
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
jonathanlab
force-pushed
the
ux/file-picker-quill
branch
from
e33ce98 to
9095035
Compare
jonathanlab
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilePicker(Cmd+P jump-to-file) fromcmdk+ RadixPopoverto quillAutocomplete*insideDialog— same shape as the command palette in feat(code): cmd palette on quill autocomplete + bump quill #2100.FilePicker.css(cmdk-specific selectors); quill primitives ship the styling.items={sections}+filter={null}so base-ui doesn't re-filter on top of fzf's fuzzy ranking.pt-1on the list when the first section is unlabeled (quill zeroes list padding-top afterAutocompleteStatus).Stacked on #2100 (
ux/cmd-menu). Merge that first.Test plan
pnpm --filter code typecheckclean.